Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rm sizings #747

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: rm sizings #747

merged 2 commits into from
Jan 16, 2025
+19 −54

Conversation

boecklim
Copy link
Collaborator

Description of Changes

  • Upgrade echo
  • Remove logic to calculate txs sizes as they are not used

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@boecklim boecklim changed the title Fix/rm sizings fix: rm sizings Jan 15, 2025
@boecklim boecklim self-assigned this Jan 15, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@boecklim boecklim merged commit ab88b5a into main Jan 16, 2025
7 of 9 checks passed
@boecklim boecklim deleted the fix/rm-sizings branch January 16, 2025 08:05
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
@boecklim
fix: rm sizings (#747)
bd02bb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shotasilagadzetaal shotasilagadzetaal shotasilagadzetaal approved these changes

Assignees

@boecklim boecklim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boecklim @shotasilagadzetaal